Teach update.sh how to optionally install clang-tools-extra.

Teach update.sh how to optionally install clang-tools-extra.

clang-tools-extra contains several useful utilities for refactoring such
as clang-format and (eventually) clang-format-diff.py.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181992

[Nico, 2013-02-12 00:28:08]

https://codereview.chromium.org/12213081/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/12213081/diff/1/tools/clang/scripts/update.sh...
tools/clang/scripts/update.sh:250: fi
What should happen if you build with --with-tools-extra once and then don't pass
it the next time round? As is, you'll end up with an inconsistent checkout. This
should either rm -rf the tools/extra dir again or update tools/extra if it
exists.

[dcheng, 2013-02-12 02:00:41]

https://codereview.chromium.org/12213081/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/12213081/diff/1/tools/clang/scripts/update.sh...
tools/clang/scripts/update.sh:250: fi
On 2013/02/12 00:28:08, Nico wrote:
> What should happen if you build with --with-tools-extra once and then don't
pass
> it the next time round? As is, you'll end up with an inconsistent checkout.
This
> should either rm -rf the tools/extra dir again or update tools/extra if it
> exists.

Good point. I've updated this to rm -rf if --with-tools-extra is not passed
again. I also fixed a stale comment in the --help.

[Nico, 2013-02-12 02:05:24]

https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update...
tools/clang/scripts/update.sh:251: rm -rf "${CLANG_TOOLS_EXTRA_DIR}"
Since you went down this route: Do you want to run `svn status` and check if
there are any modified files before blowing it away? Or is it unlikely enough
that someone will change that directory?

[dcheng, 2013-02-12 02:09:22]

https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update...
tools/clang/scripts/update.sh:251: rm -rf "${CLANG_TOOLS_EXTRA_DIR}"
On 2013/02/12 02:05:24, Nico wrote:
> Since you went down this route: Do you want to run `svn status` and check if
> there are any modified files before blowing it away? Or is it unlikely enough
> that someone will change that directory?

I don't expect people to be making changes in this directory since I'd expect
anyone who expects to contribute to LLVM/clang to do so outside of
third_party/llvm in Chrome =)

If this is a bad assumption, I'm happy to change it.

[Nico, 2013-02-12 02:09:39]

Ok, lgtm

On Mon, Feb 11, 2013 at 6:09 PM,  <dcheng@chromium.org> wrote:
>
>
https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update.sh
> File tools/clang/scripts/update.sh (right):
>
>
https://codereview.chromium.org/12213081/diff/5001/tools/clang/scripts/update...
> tools/clang/scripts/update.sh:251: rm -rf "${CLANG_TOOLS_EXTRA_DIR}"
> On 2013/02/12 02:05:24, Nico wrote:
>>
>> Since you went down this route: Do you want to run `svn status` and
>
> check if
>>
>> there are any modified files before blowing it away? Or is it unlikely
>
> enough
>>
>> that someone will change that directory?
>
>
> I don't expect people to be making changes in this directory since I'd
> expect anyone who expects to contribute to LLVM/clang to do so outside
> of third_party/llvm in Chrome =)
>
> If this is a bad assumption, I'm happy to change it.
>
> https://codereview.chromium.org/12213081/

[commit-bot: I haz the power, 2013-02-12 02:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/12213081/5001

[commit-bot: I haz the power, 2013-02-12 03:17:46]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-02-12 05:27:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/12213081/5001

[commit-bot: I haz the power, 2013-02-12 06:24:19]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...