Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/objects.cc

Issue 12213080: Use EXTERNAL_REFERENCE instead of RUNTIME_ENTRY for deoptimization entries for ARM and MIPS (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8812 matching lines...) Expand 10 before | Expand all | Expand 10 after
8823 UNREACHABLE(); 8823 UNREACHABLE();
8824 break; 8824 break;
8825 } 8825 }
8826 return NULL; 8826 return NULL;
8827 } 8827 }
8828 8828
8829 8829
8830 void Code::PrintDeoptLocation(int bailout_id) { 8830 void Code::PrintDeoptLocation(int bailout_id) {
8831 const char* last_comment = NULL; 8831 const char* last_comment = NULL;
8832 int mask = RelocInfo::ModeMask(RelocInfo::COMMENT) 8832 int mask = RelocInfo::ModeMask(RelocInfo::COMMENT)
8833 | RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY); 8833 | RelocInfo::ModeMask(RelocInfo::RUNTIME_ENTRY)
8834 | RelocInfo::ModeMask(RelocInfo::EXTERNAL_REFERENCE);
8834 for (RelocIterator it(this, mask); !it.done(); it.next()) { 8835 for (RelocIterator it(this, mask); !it.done(); it.next()) {
8835 RelocInfo* info = it.rinfo(); 8836 RelocInfo* info = it.rinfo();
8836 if (info->rmode() == RelocInfo::COMMENT) { 8837 if (info->rmode() == RelocInfo::COMMENT) {
8837 last_comment = reinterpret_cast<const char*>(info->data()); 8838 last_comment = reinterpret_cast<const char*>(info->data());
8838 } else if (last_comment != NULL && 8839 } else if (last_comment != NULL &&
8839 bailout_id == Deoptimizer::GetDeoptimizationId( 8840 bailout_id == Deoptimizer::GetDeoptimizationId(
8840 info->target_address(), Deoptimizer::EAGER)) { 8841 info->target_address(), Deoptimizer::EAGER)) {
8841 CHECK(info->rmode() == RelocInfo::RUNTIME_ENTRY); 8842 CHECK(info->rmode() == RelocInfo::RUNTIME_ENTRY ||
8843 info->rmode() == RelocInfo::EXTERNAL_REFERENCE);
8842 PrintF(" %s\n", last_comment); 8844 PrintF(" %s\n", last_comment);
8843 return; 8845 return;
8844 } 8846 }
8845 } 8847 }
8846 } 8848 }
8847 8849
8848 8850
8849 // Identify kind of code. 8851 // Identify kind of code.
8850 const char* Code::Kind2String(Kind kind) { 8852 const char* Code::Kind2String(Kind kind) {
8851 switch (kind) { 8853 switch (kind) {
(...skipping 5045 matching lines...) Expand 10 before | Expand all | Expand 10 after
13897 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13899 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13898 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13900 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13899 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13901 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13900 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13902 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13901 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13903 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13902 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13904 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13903 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13905 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13904 } 13906 }
13905 13907
13906 } } // namespace v8::internal 13908 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698