[Autofill] Credit Card validation for rAc.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index aa556a7ed4533598a0287a312c56866bbab1c57e..3281fafc4f198237e9a1e0d23247c565ebbb4b49 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -433,11 +433,33 @@ void AutofillDialogControllerImpl::EditClickedForSection(
 
 bool AutofillDialogControllerImpl::InputIsValid(AutofillFieldType type,
                                                 const string16& value) {
+  using base::Time;

[Evan Stade, 2013/02/11 00:25:14]

No longer needed

[groby-ooo-7-16, 2013/02/11 22:47:53]

Done.

+
   // TODO(groby): Add the missing checks.
   switch (type) {
+    case EMAIL_ADDRESS: break;

[Evan Stade, 2013/02/11 00:25:14]

I would prefer you put break on its own line (or at least be consistent about
it)

[groby-ooo-7-16, 2013/02/11 22:47:53]

Done.

+
     case CREDIT_CARD_NUMBER:
       return autofill::IsValidCreditCardNumber(value);
+    case CREDIT_CARD_NAME: break;
+    case CREDIT_CARD_EXP_MONTH:
+    case CREDIT_CARD_EXP_4_DIGIT_YEAR:
+      NOTREACHED() << "Validation is not called for <select>";

[Evan Stade, 2013/02/11 00:25:14]

Can we remove this block and let the default case handle it?

[groby-ooo-7-16, 2013/02/11 22:47:53]

I'd prefer to leave this NOTREACHED. If program flow gets here, something
substantially different from the default flow is broken.

If you still insist, I'm not super-tied to it :)
On 2013/02/11 00:25:14, Evan Stade wrote:

+      break;
+    case CREDIT_CARD_VERIFICATION_CODE:
+      return autofill::IsValidCreditCardCSC(value);
+
+    case ADDRESS_HOME_LINE1:
+      break;
+    case ADDRESS_HOME_LINE2:
+      return true;  // Line 2 is optional - always valid.
+    case ADDRESS_HOME_CITY:
+    case ADDRESS_HOME_STATE:
+    case ADDRESS_HOME_ZIP:
+      break;
+
     default:
+      NOTREACHED() << "Trying to validate unknown field";

[Ilya Sherman, 2013/02/11 05:39:51]

nit: Please remove the logging text.  You can include it as a comment above this
line if you'd like.

[groby-ooo-7-16, 2013/02/11 22:47:53]

Done.

       break;
   }