[Autofill] Credit Card validation for rAc.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/string_split.h"
@@ skipping 415 matching lines @@
 
     FillInputFromFormGroup(form_group, inputs);
   }
 
   section_editing_state_[section] = true;
   view_->UpdateSection(section);
 }
 
 bool AutofillDialogControllerImpl::InputIsValid(AutofillFieldType type,
                                                 const string16& value) {
+  using base::Time;
   // TODO(groby): Add the missing checks.
   switch (type) {
+    case CREDIT_CARD_NAME: break;
     case CREDIT_CARD_NUMBER:
       return autofill::IsValidCreditCardNumber(value);
+    case CREDIT_CARD_EXP_MONTH:
+      // TODO(groby): Cross-field dependency, needs year. Cannot validate.
+      break;
+    case CREDIT_CARD_EXP_2_DIGIT_YEAR:

[Evan Stade, 2013/02/08 15:48:14]

You only need to handle the types in Show()

[groby-ooo-7-16, 2013/02/09 00:01:49]

Done. 

Added NOTREACHED default to make clear this can't be validated.

On 2013/02/08 15:48:14, Evan Stade wrote:

+      return autofill::IsValidCreditCardExpirationYear(value, 2, Time::Now());
+    case CREDIT_CARD_EXP_4_DIGIT_YEAR:
+      return autofill::IsValidCreditCardExpirationYear(value, 4, Time::Now());
+    case CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR:
+      return autofill::IsValidCreditCardExpirationDate(value, 4, Time::Now());
+    case CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR:
+      return autofill::IsValidCreditCardExpirationDate(value, 4, Time::Now());
+    case CREDIT_CARD_VERIFICATION_CODE:
+      // TODO(groby):: Cross-field dependency - would work better w/ CC type.
+      return autofill::IsValidCreditCardCSC(value);
     default:
       break;
   }
 
   return !value.empty();
 }
 
 void AutofillDialogControllerImpl::UserEditedOrActivatedInput(
     const DetailInput* input,
     DialogSection section,
@@ skipping 498 matching lines @@
     DialogSection section) {
   return const_cast<DetailInputs*>(&RequestedFieldsForSection(section));
 }
 
 void AutofillDialogControllerImpl::HidePopup() {
   if (popup_controller_)
     popup_controller_->Hide();
 }
 
 }  // namespace autofill