chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r181832 Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm

diff --git a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm

index a9740bbbeef9d3a44314fd9a36989a97db681d65..a8c7bdd407229bb40c7b212d29ce60660d76b1ee 100644

--- a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm

+++ b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm

@@ -11,6 +11,7 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

#import "chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.h"

#import "chrome/browser/ui/cocoa/applescript/constants_applescript.h"

@@ -24,8 +25,8 @@

arrayWithCapacity:BrowserList::size()];

// Iterate through all browsers and check if it closing,

// if not add it to list.

- for (BrowserList::const_iterator browserIterator = BrowserList::begin();

- browserIterator != BrowserList::end(); ++browserIterator) {

+ for (chrome::BrowserIterator browserIterator; !browserIterator.done();

+ browserIterator.Next()) {

if ((*browserIterator)->IsAttemptingToCloseBrowser())

continue;

« no previous file with comments | « chrome/browser/download/download_status_updater_win.cc ('k') | chrome/browser/ui/gtk/gtk_theme_service.cc » ('j') | no next file with comments »