Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2522)

Unified Diff: chrome/browser/app_controller_mac_browsertest.mm

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r181832 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/chromeos/boot_times_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac_browsertest.mm
diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm
index ff342780e0aadf56db276b5108204b86ce1fc5d7..aec0f005e38adf52e48998ea4b941f4177cf0936 100644
--- a/chrome/browser/app_controller_mac_browsertest.mm
+++ b/chrome/browser/app_controller_mac_browsertest.mm
@@ -10,6 +10,8 @@
#import "chrome/browser/app_controller_mac.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_list_impl.h"
+#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#import "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -20,12 +22,18 @@ namespace {
class AppControllerPlatformAppBrowserTest : public InProcessBrowserTest {
protected:
- AppControllerPlatformAppBrowserTest() {}
+ AppControllerPlatformAppBrowserTest()
+ : native_browser_list(chrome::BrowserListImpl::GetInstance(
+ chrome::HOST_DESKTOP_TYPE_NATIVE)) {
+ }
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitchASCII(switches::kAppId,
"1234");
}
+
+ // Mac only has the native desktop.
+ const chrome::BrowserListImpl* native_browser_list;
};
// Test that if only a platform app window is open and no browser windows are
@@ -34,17 +42,20 @@ IN_PROC_BROWSER_TEST_F(AppControllerPlatformAppBrowserTest,
PlatformAppReopenWithWindows) {
scoped_nsobject<AppController> ac([[AppController alloc] init]);
NSUInteger old_window_count = [[NSApp windows] count];
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:YES];
EXPECT_TRUE(result);
EXPECT_EQ(old_window_count, [[NSApp windows] count]);
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
}
class AppControllerWebAppBrowserTest : public InProcessBrowserTest {
protected:
- AppControllerWebAppBrowserTest() {}
+ AppControllerWebAppBrowserTest()
+ : native_browser_list(chrome::BrowserListImpl::GetInstance(
+ chrome::HOST_DESKTOP_TYPE_NATIVE)) {
+ }
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitchASCII(switches::kApp, GetAppURL());
@@ -53,19 +64,22 @@ class AppControllerWebAppBrowserTest : public InProcessBrowserTest {
std::string GetAppURL() const {
return "http://example.com/";
}
+
+ // Mac only has the native desktop.
+ const chrome::BrowserListImpl* native_browser_list;
};
// Test that in web app mode a reopen event opens the app URL.
IN_PROC_BROWSER_TEST_F(AppControllerWebAppBrowserTest,
WebAppReopenWithNoWindows) {
scoped_nsobject<AppController> ac([[AppController alloc] init]);
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:NO];
EXPECT_FALSE(result);
- EXPECT_EQ(2u, BrowserList::size());
+ EXPECT_EQ(2u, native_browser_list->size());
- Browser* browser = *(BrowserList::begin());
+ Browser* browser = native_browser_list->get(0);
GURL current_url =
browser->tab_strip_model()->GetActiveWebContents()->GetURL();
EXPECT_EQ(GetAppURL(), current_url.spec());
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/chromeos/boot_times_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698