chrome/browser/chromeos/media/media_player_browsertest.cc - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/media/media_player_browsertest.cc

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/extensions/file_manager_util.cc ('K') | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/chromeos/memory/oom_priority_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/media/media_player_browsertest.cc

diff --git a/chrome/browser/chromeos/media/media_player_browsertest.cc b/chrome/browser/chromeos/media/media_player_browsertest.cc

index b5b15caf1657830ceac8a2edeb3820141f957eb7..4931113a15e8147a9f9000efc0078cd8776ba6e5 100644

--- a/chrome/browser/chromeos/media/media_player_browsertest.cc

+++ b/chrome/browser/chromeos/media/media_player_browsertest.cc

@@ -7,7 +7,7 @@

#include "base/utf_string_conversions.h"

#include "chrome/browser/chromeos/media/media_player.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -24,9 +24,8 @@ class MediaPlayerBrowserTest : public InProcessBrowserTest {

bool IsBrowserVisible(Browser* browser) {

if (browser == NULL)

return false;

- for (BrowserList::const_iterator it = BrowserList::begin();

- it != BrowserList::end(); ++it) {

- if ((*it)->is_type_popup() && (*it)->is_app() && (*it) == browser)

+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {

+ if (it->is_type_popup() && it->is_app() && (*it) == browser)

return true;

}

return false;