chrome/browser/chromeos/boot_times_loader.cc - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/boot_times_loader.cc

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/app_controller_mac_browsertest.mm ('k') | chrome/browser/chromeos/extensions/file_manager_util.cc » ('j') | chrome/browser/chromeos/extensions/file_manager_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/boot_times_loader.cc

diff --git a/chrome/browser/chromeos/boot_times_loader.cc b/chrome/browser/chromeos/boot_times_loader.cc

index 24f7bcff744d87f74667d4fe11a5a89e56945ca9..b10bcf1f0be8738d97a6718c8c30c841a7af9c30 100644

--- a/chrome/browser/chromeos/boot_times_loader.cc

+++ b/chrome/browser/chromeos/boot_times_loader.cc

@@ -25,7 +25,7 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/login/authentication_notification_details.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

@@ -56,9 +56,7 @@ RenderWidgetHost* GetRenderWidgetHost(NavigationController* tab) {

const std::string GetTabUrl(RenderWidgetHost* rwh) {

RenderWidgetHostView* rwhv = rwh->GetView();

- for (BrowserList::const_iterator it = BrowserList::begin();

- it != BrowserList::end();

- ++it) {

+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {

Browser* browser = *it;

for (int i = 0, tab_count = browser->tab_strip_model()->count();

i < tab_count;