chrome/browser/app_controller_mac.mm - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 5d8acbc036003b056b764f47e780538b813809f6..4a97b1c74d2f30b6f324e3150aae5f736fadef6b 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -41,6 +41,7 @@

#include "chrome/browser/ui/browser_command_controller.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_mac.h"

#include "chrome/browser/ui/browser_window.h"

@@ -980,8 +981,7 @@ void RecordLastRunAppBundlePath() {

// visible windows are panels or notifications, we still need to open a new

// window.

if (flag) {

- for (BrowserList::const_iterator iter = BrowserList::begin();

- iter != BrowserList::end(); ++iter) {

+ for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {

Browser* browser = *iter;

if (browser->is_type_tabbed() || browser->is_type_popup())

return YES;

« no previous file with comments | « no previous file | chrome/browser/app_controller_mac_browsertest.mm » ('j') | chrome/browser/chromeos/extensions/file_manager_util.cc » ('J')