chrome/browser/ui/gtk/gtk_theme_service.cc - Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/gtk_theme_service.cc

Issue 12213075: Swap deprecated BrowserList:: iterators for BrowserIterator in non-Windows code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/extensions/file_manager_util.cc ('K') | « chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm ('k') | chrome/browser/ui/gtk/gtk_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/gtk_theme_service.cc

diff --git a/chrome/browser/ui/gtk/gtk_theme_service.cc b/chrome/browser/ui/gtk/gtk_theme_service.cc

index d36a762aacbafa5fd0342fc4628afcbea40a1331..8f3793c5b2c9cd5018bc7c3db79f80d7130400be 100644

--- a/chrome/browser/ui/gtk/gtk_theme_service.cc

+++ b/chrome/browser/ui/gtk/gtk_theme_service.cc

@@ -17,7 +17,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/themes/theme_service_factory.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/gtk/chrome_gtk_frame.h"

#include "chrome/browser/ui/gtk/gtk_chrome_button.h"

@@ -653,9 +653,8 @@ void GtkThemeService::NotifyThemeChanged() {

gtk_util::SetLabelColor(it->first, color);

}

- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();

- browser_iterator != BrowserList::end(); browser_iterator++) {

- Browser* browser = (*browser_iterator);

+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {

+ Browser* browser = *it;

if (!browser->window())

continue;

GtkWindow* window = browser->window()->GetNativeWindow();