Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 12213074: BrowserList iterator methods have been phased out, delete them! (Closed)

Created:
7 years, 10 months ago by gab
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, Ben Goodger (Google)
Visibility:
Public.

Description

BrowserList iterator methods have been phased out, delete them! BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/browser/ui/browser_list.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Ben, I finally phased native-desktop only iterators out (after https://codereview.chromium.org/12213053/, https://codereview.chromium.org/12210067/, https://codereview.chromium.org/12213075/, https://codereview.chromium.org/12213091/, https://codereview.chromium.org/12207051/, and ...
7 years, 10 months ago (2013-02-11 16:28:42 UTC) #1
gab
Swapping ben for sky (see first comment for details). Thanks! Gab
7 years, 10 months ago (2013-02-11 23:08:59 UTC) #2
sky
LGTM
7 years, 10 months ago (2013-02-12 00:55:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12213074/1
7 years, 10 months ago (2013-02-12 20:43:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12213074/1
7 years, 10 months ago (2013-02-13 13:11:52 UTC) #5
gab
7 years, 10 months ago (2013-02-13 14:01:16 UTC) #6
Message was sent while issue was closed.
On 2013/02/13 13:11:52, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/gab%40chromium.org/12213074/1

I grepped ToT and there were no instances left of this method still, dcommitted
even though tree was closed to make sure this goes in before someone re-uses one
of these deprecated calls.

Cheers!
Gab

Powered by Google App Engine
This is Rietveld 408576698