Issue 12213061: Move sys_string_conversions to base/strings.

Issue 12213061: Move sys_string_conversions to base/strings. (Closed)

Created:
7 years, 10 months ago by brettw

Modified:
7 years, 10 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move sys_string_conversions to base/strings. This updates callers in base but I left a forwarding header so I can the rest in pieces (there are >300). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181345

Patch Set 1 #

Patch Set 2 : rm him #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -747 lines)			Patch
M	base/base.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/base.gypi	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/file_path.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_posix.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_version_info_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/file_util_icu.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/icu_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/rtl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/i18n/rtl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/ios/device_util.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/ios/device_util_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/mac/bundle_locations.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/mac/foundation_util.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/mac/mac_util.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	base/strings/sys_string_conversions.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/strings/sys_string_conversions_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	base/strings/sys_string_conversions_mac_unittest.mm	View		1 chunk	+8 lines, -5 lines	0 comments	Download
A +	base/strings/sys_string_conversions_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	base/strings/sys_string_conversions_unittest.cc	View	1	7 chunks	+11 lines, -12 lines	0 comments	Download
A +	base/strings/sys_string_conversions_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/sys_info_ios.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/sys_string_conversions.h	View		1 chunk	+4 lines, -80 lines	0 comments	Download
D	base/sys_string_conversions_mac.mm	View		1 chunk	+0 lines, -187 lines	0 comments	Download
D	base/sys_string_conversions_mac_unittest.mm	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	base/sys_string_conversions_posix.cc	View		1 chunk	+0 lines, -161 lines	0 comments	Download
D	base/sys_string_conversions_unittest.cc	View		1 chunk	+0 lines, -188 lines	0 comments	Download
D	base/sys_string_conversions_win.cc	View		1 chunk	+0 lines, -70 lines	0 comments	Download
M	base/time.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages