Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: remoting/host/installer/mac/Scripts/remoting_postflight.sh

Issue 12213059: Direct host output to a specific log file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/installer/mac/Scripts/remoting_postflight.sh
===================================================================
--- remoting/host/installer/mac/Scripts/remoting_postflight.sh (revision 181302)
+++ remoting/host/installer/mac/Scripts/remoting_postflight.sh (working copy)
@@ -13,6 +13,7 @@
PAM_CONFIG=/etc/pam.d/chrome-remote-desktop
ENABLED_FILE="$HELPERTOOLS/$NAME.me2me_enabled"
ENABLED_FILE_BACKUP="$ENABLED_FILE.backup"
+LOG_FILE=/var/log/org.chromium.chromoting.log
KSADMIN=/Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/MacOS/ksadmin
KSUPDATE=https://tools.google.com/service/update2
@@ -63,6 +64,14 @@
logger PAM config has local edits. Not updating.
fi
+# Create the log file (if this isn't created ahead of time
+# then directing output from the service there won't work).
+# Make sure admins have write privileges (CRD users are
+# typically admins)
+touch "$LOG_FILE"
+chown :admin "$LOG_FILE"
+chmod 664 "$LOG_FILE"
Jamie 2013/02/08 23:45:11 As with the conf file, 660 would be safer.
+
# Load the service.
# The launchctl command we'd like to run:
# launchctl load -w -S Aqua $PLIST

Powered by Google App Engine
This is Rietveld 408576698