Plumb HostDesktopType through window_sizer_ash.cc.

Plumb HostDesktopType through window_sizer_ash.cc.

Getting rid of some more native desktop only BrowserList::const_iterator.

BUG=129187
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182002

[gab, 2013-02-11 15:39:42]

@ben: ping

Thanks,
Gab

[gab, 2013-02-11 23:07:57]

Swapping ben for sky.

Thanks!
Gab

[sky, 2013-02-12 00:52:20]

I think the change needs to a bit more subtle. Specifically we should use
WindowSizerAsh for HOST_DESKTOP_TYPE_ASH and WindowSizerWin for
HOST_DESKTOP_TYPE_NATIVE.

[gab, 2013-02-12 16:51:13]

On 2013/02/12 00:52:20, sky wrote:
> I think the change needs to a bit more subtle. Specifically we should use
> WindowSizerAsh for HOST_DESKTOP_TYPE_ASH and WindowSizerWin for
> HOST_DESKTOP_TYPE_NATIVE.

Right, I modified this change to use the ASH BrowserListImpl directly. While
this is still incorrect in dual desktops environments (as you stated we need two
window sizers to live side-by-side; choosing 1 based on compile time flags or
runtime properties isn't sufficient (ref: chrome::ShouldOpenAshOnStartup())),
this is not worst than before imo and is the last blocker to get rid of the
BrowserList:: iterators.

There is currently a TODO(beng) to fix this (window_sizer.cc:204) -- the
referenced crbug.com/133312 is currently assigned to scottmg, but hasn't seen
commits since October 30th.

I'm happy to later work on having the window sizer choose the right handler at
runtime, but it's currently a very compile-time thing (in fact
window_sizer_win.cc isn't even compiled on Aura -- the saved and last active
state are only set by the native desktop, but used by the ash window sizer it
looks like). I don't think this should block the BrowserList:: iterators
removal.

Cheers!
Gab

[sky, 2013-02-12 18:25:06]

LGTM

[commit-bot: I haz the power, 2013-02-12 18:35:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/12213053/4002

[commit-bot: I haz the power, 2013-02-12 20:47:28]

Change committed as 182002