Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1221303021: Change %s in format to %ls. (Closed)

Created:
5 years, 5 months ago by bcwhite
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change %s in format to %ls. Though %s works on Windows which is the only OS that compiles this file, it is non-portable and triggers a DCHECK. BUG=489801 Committed: https://crrev.com/9f235293834fedd7ffac67e44c3a5f2db56246f7 Cr-Commit-Position: refs/heads/master@{#337971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/google/google_update_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bcwhite
5 years, 5 months ago (2015-07-09 00:57:14 UTC) #2
James Hawkins
lgtm
5 years, 5 months ago (2015-07-09 01:49:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303021/1
5 years, 5 months ago (2015-07-09 02:24:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 02:29:53 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 02:30:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f235293834fedd7ffac67e44c3a5f2db56246f7
Cr-Commit-Position: refs/heads/master@{#337971}

Powered by Google App Engine
This is Rietveld 408576698