Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1221303020: Add tools/flatten to flatten nested pictures in .skps. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add tools/flatten to flatten nested pictures in .skps. Tested by running on skps/sp_desk_nytimes.skp. The output .skp had no nested draw picture calls, and the files were both 9.3M. BUG=skia: Committed: https://skia.googlesource.com/skia/+/60c047557559e5410063452e59d65377e813e5f2

Patch Set 1 #

Patch Set 2 : good catch clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M gyp/tools.gyp View 2 chunks +11 lines, -0 lines 0 comments Download
A tools/flatten.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
5 years, 5 months ago (2015-07-08 16:02:32 UTC) #2
rmistry
lgtm
5 years, 5 months ago (2015-07-08 16:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303020/1
5 years, 5 months ago (2015-07-08 16:53:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1934)
5 years, 5 months ago (2015-07-08 16:55:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303020/20001
5 years, 5 months ago (2015-07-08 16:58:08 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:06:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/60c047557559e5410063452e59d65377e813e5f2

Powered by Google App Engine
This is Rietveld 408576698