Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: src/lookup.h

Issue 1221303019: Fix keyed access of primitive objects in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/liveedit.cc ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 90edd8b43d032f94aa0661105792a1eeff62e1f9..20a4b73fb0d4f22e32e1c18edcd0153c8c367e13 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -56,7 +56,7 @@ class LookupIterator final BASE_EMBEDDED {
// kMaxUInt32 isn't a valid index.
index_(kMaxUInt32),
receiver_(receiver),
- holder_(GetRoot(receiver_, isolate_)),
+ holder_(GetRoot(isolate_, receiver)),
holder_map_(holder_->map(), isolate_),
initial_holder_(holder_),
number_(DescriptorArray::kNotFound) {
@@ -102,7 +102,7 @@ class LookupIterator final BASE_EMBEDDED {
name_(),
index_(index),
receiver_(receiver),
- holder_(GetRoot(receiver_, isolate_)),
+ holder_(GetRoot(isolate, receiver, index)),
holder_map_(holder_->map(), isolate_),
initial_holder_(holder_),
number_(DescriptorArray::kNotFound) {
@@ -196,7 +196,8 @@ class LookupIterator final BASE_EMBEDDED {
DCHECK(IsFound());
return Handle<T>::cast(holder_);
}
- static Handle<JSReceiver> GetRoot(Handle<Object> receiver, Isolate* isolate);
+ static Handle<JSReceiver> GetRoot(Isolate* isolate, Handle<Object> receiver,
+ uint32_t index = kMaxUInt32);
bool HolderIsReceiverOrHiddenPrototype() const;
/* ACCESS_CHECK */
« no previous file with comments | « src/liveedit.cc ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698