Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: src/execution.cc

Issue 1221303019: Fix keyed access of primitive objects in the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index fc0e50e5530f2205f8145363d4db7ec31758f037..cdfa787447203b677f68fd499404e04f8b1a0db4 100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -551,6 +551,7 @@ MaybeHandle<Object> Execution::ToDetailString(
MaybeHandle<Object> Execution::ToObject(
Isolate* isolate, Handle<Object> obj) {
if (obj->IsSpecObject()) return obj;
+ // TODO(verwaest): Use Object::ToObject but throw an exception on failure.
RETURN_NATIVE_CALL(to_object, { obj });
}
« no previous file with comments | « src/api.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698