Fix keyed access of primitive objects in the runtime.

Fix keyed access of primitive objects in the runtime.
For now it uses a pretty slow path for accessing strings by wrapping it into a new temporary wrapper.

BUG=v8:4042, v8:3088
LOG=y

Committed: https://crrev.com/1f2755bf35a98d0baefcbe6772c93ad1a7fc1901
Cr-Commit-Position: refs/heads/master@{#29576}

[Toon Verwaest, 2015-07-08 15:50:10]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-07-08 15:50:11]

ptal

[Igor Sheludko, 2015-07-10 10:02:42]

Please update all the other calls to JSReceiver::SetElement() and
JSObject::SetElement() with calls to Object::SetElement.

lgtm once the comments are addressed.

https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/1221303019/diff/50001/src/lookup.cc#newcode62
src/lookup.cc:62: Handle<JSReceiver> LookupIterator::GetRoot() {
I think it is better to keep GetRoot() static given that you call it during
object construction. You just need an additional parameter "bool is_element".

https://codereview.chromium.org/1221303019/diff/50001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1221303019/diff/50001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:794: JSReceiver::SetElement(isolate, array, 0, name,
SLOPPY).Check();
Object::SetElement(...) here and below.

[Toon Verwaest, 2015-07-10 15:23:28]

Addressed comments. I'm just passing in index with default MaxUInt32 and
checking for that value, just like IsElement does internally. I think that's
fine since it's all private to the LookupIterator.

[Toon Verwaest, 2015-07-10 15:23:35]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-10 15:23:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1221303019/#ps90001
(title: "Rebase + addressing comments")

[commit-bot: I haz the power, 2015-07-10 15:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221303019/90001

[commit-bot: I haz the power, 2015-07-10 15:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 15:32:13]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Toon Verwaest, 2015-07-10 15:44:31]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-10 15:44:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1221303019/#ps110001
(title: "Fix")

[commit-bot: I haz the power, 2015-07-10 15:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1221303019/110001

[commit-bot: I haz the power, 2015-07-10 16:11:06]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2015-07-10 16:11:17]

Patchset 7 (id:??) landed as
https://crrev.com/1f2755bf35a98d0baefcbe6772c93ad1a7fc1901
Cr-Commit-Position: refs/heads/master@{#29576}