Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1221303014: [turbofan] Move RawMachineAssembler back to src/compiler. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, picksi1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move RawMachineAssembler back to src/compiler. The RawMachineAssembler will be used to build the interpreter, so it needs to move back to src/compiler. This reverts commit b5b00cc031c15263bbc4e8e8b2bef01b6fdfd284. BUG=v8:4280 LOG=N Committed: https://crrev.com/ea560a9be9eb48f652cd000162d73d135a6fb938 Cr-Commit-Position: refs/heads/master@{#29519}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -809 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + src/compiler/raw-machine-assembler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/compiler/raw-machine-assembler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
A test/cctest/compiler/instruction-selector-tester.h View 1 chunk +127 lines, -0 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
D test/unittests/compiler/raw-machine-assembler.h View 1 1 chunk +0 lines, -543 lines 0 comments Download
D test/unittests/compiler/raw-machine-assembler.cc View 1 1 chunk +0 lines, -260 lines 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303014/1
5 years, 5 months ago (2015-07-07 13:13:01 UTC) #2
rmcilroy
Benedikt, could you have a look please, thanks.
5 years, 5 months ago (2015-07-07 13:13:43 UTC) #4
rmcilroy
Benedikt, could you have a look please, thanks.
5 years, 5 months ago (2015-07-07 13:13:43 UTC) #5
rmcilroy
Benedikt, could you have a look please, thanks.
5 years, 5 months ago (2015-07-07 13:13:45 UTC) #6
Benedikt Meurer
Yep, LGTM.
5 years, 5 months ago (2015-07-07 13:14:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2085) (exceeded global ...
5 years, 5 months ago (2015-07-07 13:15:03 UTC) #9
rmcilroy
+picksi. Thanks!
5 years, 5 months ago (2015-07-07 13:27:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303014/20001
5 years, 5 months ago (2015-07-07 13:28:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/6439) v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 13:29:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303014/20001
5 years, 5 months ago (2015-07-07 14:33:09 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 15:02:47 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:03:01 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea560a9be9eb48f652cd000162d73d135a6fb938
Cr-Commit-Position: refs/heads/master@{#29519}

Powered by Google App Engine
This is Rietveld 408576698