Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1221303013: Allow parsing SVG <paint> and <color> properties in the color fast-path (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow parsing SVG <paint> and <color> properties in the color fast-path The following properties: fill flood-color lighting-color stop-color stroke Will all accept a single <color> as a valid value. This means they can be handled by the <color> parsing fast-path, which reduces the parsing cost for these properties which often appear as presentation attributes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199022

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 5 months ago (2015-07-13 13:15:45 UTC) #2
Timothy Loh
On 2015/07/13 13:15:45, fs wrote: lgtm
5 years, 5 months ago (2015-07-16 00:46:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221303013/1
5 years, 5 months ago (2015-07-16 08:28:43 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:50:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199022

Powered by Google App Engine
This is Rietveld 408576698