Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/property.h

Issue 12213012: Split AccessorInfo into DeclaredAccessorInfo and ExecutableAccessorInfo (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 } 311 }
312 312
313 bool IsDataProperty() { 313 bool IsDataProperty() {
314 switch (type()) { 314 switch (type()) {
315 case FIELD: 315 case FIELD:
316 case NORMAL: 316 case NORMAL:
317 case CONSTANT_FUNCTION: 317 case CONSTANT_FUNCTION:
318 return true; 318 return true;
319 case CALLBACKS: { 319 case CALLBACKS: {
320 Object* callback = GetCallbackObject(); 320 Object* callback = GetCallbackObject();
321 return callback->IsAccessorInfo() || callback->IsForeign(); 321 return callback->IsExecutableAccessorInfo() || callback->IsForeign();
Sven Panne 2013/02/07 10:01:03 Shouldn't the DescriptorAccessorInfos be data prop
322 } 322 }
323 case HANDLER: 323 case HANDLER:
324 case INTERCEPTOR: 324 case INTERCEPTOR:
325 case TRANSITION: 325 case TRANSITION:
326 case NONEXISTENT: 326 case NONEXISTENT:
327 return false; 327 return false;
328 } 328 }
329 UNREACHABLE(); 329 UNREACHABLE();
330 return false; 330 return false;
331 } 331 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 JSReceiver* holder_; 473 JSReceiver* holder_;
474 int number_; 474 int number_;
475 bool cacheable_; 475 bool cacheable_;
476 PropertyDetails details_; 476 PropertyDetails details_;
477 }; 477 };
478 478
479 479
480 } } // namespace v8::internal 480 } } // namespace v8::internal
481 481
482 #endif // V8_PROPERTY_H_ 482 #endif // V8_PROPERTY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698