sdk/lib/async/stream_pipe.dart - Issue 12213009: Fix bad handling of done events in _ForwardingStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_pipe.dart

Issue 12213009: Fix bad handling of done events in _ForwardingStream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added more chaining in the test. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/stream_pipe.dart

diff --git a/sdk/lib/async/stream_pipe.dart b/sdk/lib/async/stream_pipe.dart

index 8867ee005b1d633ae5915b14f9f2e417440f6cf0..aaa34b059362638f8f9b04fad2f50f6eaccc9eea 100644

--- a/sdk/lib/async/stream_pipe.dart

+++ b/sdk/lib/async/stream_pipe.dart

@@ -215,6 +215,8 @@ class _ForwardingStreamSubscription<S, T>

}

void _handleDone() {

+ // On a done-event, we have already been unsubscribed.

+ _subscription = null;

_stream._handleDone(this);

}

« no previous file with comments | « no previous file | tests/lib/async/stream_transform_test.dart » ('j') | no next file with comments »