Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: tests/lib/async/stream_transform_test.dart

Issue 12213009: Fix bad handling of done events in _ForwardingStream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/stream_transform_test.dart
diff --git a/tests/lib/async/stream_transform_test.dart b/tests/lib/async/stream_transform_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..acbe03488bc49e0eadabca3c1218fb77dbb9a61e
--- /dev/null
+++ b/tests/lib/async/stream_transform_test.dart
@@ -0,0 +1,48 @@
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library stream_transform_test;
+
+import 'dart:async';
+import '../../../pkg/unittest/lib/unittest.dart';
+import 'event_helper.dart';
+
+
+main() {
+ // Regression tests for http://dartbug.com/8311
+
+ test("simpleDone", () {
+ StreamController c = new StreamController();
+ Stream out = c.stream.catchError((x){}).catchError((x){});
+ out.listen((v){}, onDone: expectAsync0(() {}));
+ // Should not throw.
+ c.close();
+ });
+
+ test("with events", () {
+ StreamController c = new StreamController();
+ Events expected = new Events.fromIterable([6, 8, 10]);
+ Events input = new Events.fromIterable([1, 2, 3, 4, 5]);
+ Events actual = new Events.capture(
+ c.stream.map((x) => x * 2).where((x) => x > 5));
+ actual.onDone(() {
floitsch 2013/02/05 15:09:51 expectAsync0
Lasse Reichstein Nielsen 2013/02/07 10:16:58 Done.
+ Expect.listEquals(expected.events, actual.events);
+ });
+ input.replay(c);
+ });
+
+ test("paused events", () {
+ StreamController c = new StreamController();
+ Events expected = new Events.fromIterable([6, 8, 10]);
+ Events input = new Events.fromIterable([1, 2, 3, 4, 5]);
+ Events actual = new Events.capture(
+ c.stream.map((x) => x * 2).where((x) => x > 5));
+ actual.onDone(expectAsync0(() {
+ Expect.listEquals(expected.events, actual.events);
+ }));
+ actual.pause();
+ input.replay(c);
+ actual.resume();
+ });
+}
floitsch 2013/02/05 15:09:51 more tests! :) some other transformations would be
Lasse Reichstein Nielsen 2013/02/07 10:16:58 That won't give any more coverage for this bug. It
« no previous file with comments | « sdk/lib/async/stream_pipe.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698