Issue 1221273002: Fix interactive_flex demo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221273002: Fix interactive_flex demo (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix interactive_flex demo There were two problems: 1) We didn't update the demo's use of RenderImage when we switched RenderImage to take a sky.Image rather than a URL. 2) Scheduling a layout no longer ensured a visual update, which meant we'd never actually flushLayout unless something else ensured a visual update. TBR=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/22768c6c1e89c92509b932253fac4307d61ad5c5

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	sky/sdk/example/rendering/interactive_flex.dart	View	4 chunks	+9 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/rendering/object.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/sdk/lib/rendering/sky_binding.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #1 (id:1) manually as 22768c6c1e89c92509b932253fac4307d61ad5c5 (presubmit successful).

5 years, 5 months ago (2015-07-04 04:35:04 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages