Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1221243009: Rewrite code to avoid dead code hints during build. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index 09455f1220d44e3a0bbcab916e7d3c54070c502f..90bc77245a06f4cd30138aa6ff50da25dcf6faad 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -3185,11 +3185,9 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
String name = backend.namer.currentIsolate;
return irBuilder.buildForeignCode(js.js.parseForeignJS(name),
const <ir.Primitive>[], NativeBehavior.PURE);
- } else {
- return buildIsolateHelperInvocation('_currentIsolate',
- CallStructure.NO_ARGS);
}
- break;
+ return buildIsolateHelperInvocation('_currentIsolate',
+ CallStructure.NO_ARGS);
case 'JS_CALL_IN_ISOLATE':
validateArgumentCount(exactly: 2);
@@ -3198,11 +3196,9 @@ class JsIrBuilderVisitor extends IrBuilderVisitor {
ir.Primitive closure = visit(argumentNodes.tail.head);
return irBuilder.buildCallInvocation(closure, CallStructure.NO_ARGS,
const <ir.Primitive>[]);
- } else {
- return buildIsolateHelperInvocation('_callInIsolate',
- CallStructure.TWO_ARGS);
}
- break;
+ return buildIsolateHelperInvocation('_callInIsolate',
+ CallStructure.TWO_ARGS);
default:
giveup(node, 'unplemented native construct: ${function.name}');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698