Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 12212188: Revert "content: convert accessibility notifications to callbacks" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/public/browser/notification_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 4ff3c54628ad98d7a60f69a2fafe7bb6177b8553..b9c2a29355bf436508f266ca991efd854a75c25b 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -1786,16 +1786,6 @@ void RenderViewHostImpl::UpdateFrameTree(
frame_tree_));
}
-void RenderViewHostImpl::SetAccessibilityLayoutCompleteCallbackForTesting(
- const base::Closure& callback) {
- accessibility_layout_callback_ = callback;
-}
-
-void RenderViewHostImpl::SetAccessibilityLoadCompleteCallbackForTesting(
- const base::Closure& callback) {
- accessibility_load_callback_ = callback;
-}
-
void RenderViewHostImpl::UpdateWebkitPreferences(
const webkit_glue::WebPreferences& prefs) {
Send(new ViewMsg_UpdateWebPreferences(GetRoutingID(), prefs));
@@ -1902,11 +1892,17 @@ void RenderViewHostImpl::OnAccessibilityNotifications(
accessibility_tree_ = param.acc_tree;
}
- if (src_type == AccessibilityNotificationLayoutComplete) {
- accessibility_layout_callback_.Run();
- } else if (src_type == AccessibilityNotificationLoadComplete) {
- accessibility_load_callback_.Run();
- }
+ NotificationType dst_type;
+ if (src_type == AccessibilityNotificationLoadComplete)
+ dst_type = NOTIFICATION_ACCESSIBILITY_LOAD_COMPLETE;
+ else if (src_type == AccessibilityNotificationLayoutComplete)
+ dst_type = NOTIFICATION_ACCESSIBILITY_LAYOUT_COMPLETE;
+ else
+ dst_type = NOTIFICATION_ACCESSIBILITY_OTHER;
+ NotificationService::current()->Notify(
+ dst_type,
+ Source<RenderViewHost>(this),
+ NotificationService::NoDetails());
}
Send(new AccessibilityMsg_Notifications_ACK(GetRoutingID()));
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/public/browser/notification_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698