Issue 12212187: [Cleanup] Files.app: Misc style fixes in Javascript code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212187: [Cleanup] Files.app: Misc style fixes in Javascript code. (Closed)

Created:
7 years, 10 months ago by yoshiki

Modified:
7 years, 10 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Cleanup] Files.app: Misc style fixes in Javascript code. - Fix wrong styles what the presubmit warns. - Change the order of '@private' and '@constructor' annotations. - Add/remove blank lines to be better readability. BUG=175657 TEST=Files.app launches. TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182432

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -75 lines)			Patch
M	chrome/browser/resources/file_manager/js/background.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/breadcrumbs_controller.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/butter_bar.js	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/directory_contents.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/directory_model.js	View		16 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_table.js	View		1 chunk	+13 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_transfer_controller.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/commands.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_encoder.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_view.js	View		5 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/media/media_controls.js	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/byte_reader.js	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/function_parallel.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/function_sequence.js	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/id3_parser.js	View		9 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/importing_dialog.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/select_album_dialog.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/slide_mode.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/source.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/tile_view.js	View		2 chunks	+2 lines, -1 line	0 comments	Download