Issue 12212185: [Cleanup] Files.app: Fill 'TODO' comments to missing descriptions in @param annotation.

Issue 12212185: [Cleanup] Files.app: Fill 'TODO' comments to missing descriptions in @param annotation. (Closed)

Created:
7 years, 10 months ago by yoshiki

Modified:
7 years, 10 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Cleanup] Files.app: Fill 'TODO' comments to missing descriptions in @param annotation. This suppresses 'E:0210: Missing docs for parameter' errors from closure linter. All changes are in comment, hence I believe this patch doesn't change any behavior. BUG=175657 TEST=none TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182417

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -0 lines)			Patch
M	chrome/browser/resources/file_manager/js/metadata/byte_reader.js	View	17 chunks	+63 lines, -0 lines	2 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/function_parallel.js	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/function_sequence.js	View	4 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/id3_parser.js	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtomasz

https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file_manager/js/metadata/byte_reader.js File chrome/browser/resources/file_manager/js/metadata/byte_reader.js (right): https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file_manager/js/metadata/byte_reader.js#newcode53 chrome/browser/resources/file_manager/js/metadata/byte_reader.js:53: * @param {number} pos //TODO(JSDOC). Space after //?

7 years, 10 months ago (2013-02-14 08:38:48 UTC) #1

mtomasz

On 2013/02/14 08:38:48, mtomasz wrote: > https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file_manager/js/metadata/byte_reader.js > File chrome/browser/resources/file_manager/js/metadata/byte_reader.js (right): > > https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file_manager/js/metadata/byte_reader.js#newcode53 > ...

7 years, 10 months ago (2013-02-14 08:38:58 UTC) #2

yoshiki

7 years, 10 months ago (2013-02-14 08:44:55 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/metadata/byte_reader.js (right):

https://codereview.chromium.org/12212185/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/metadata/byte_reader.js:53: * @param
{number} pos  //TODO(JSDOC).
Same TODO comment has been used: '//TODO(JSDOC)' (without space), hence I'm
using same expression. But I also think it is better to add a space. I'll do it
in another patch.

On 2013/02/14 08:38:48, mtomasz wrote:
> Space after //?

Expand Messages | Collapse Messages