Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chromeos/display/output_configurator.cc

Issue 12212171: Provides more types of errors for output status. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/display/output_configurator.cc
diff --git a/chromeos/display/output_configurator.cc b/chromeos/display/output_configurator.cc
index d2a5769aabf8a5af7a5103a8ca5fc27c3e9ab8dc..379bfbe28f182d8c6d5b20612215bd9f9101655c 100644
--- a/chromeos/display/output_configurator.cc
+++ b/chromeos/display/output_configurator.cc
@@ -649,7 +649,8 @@ bool OutputConfigurator::CycleDisplayMode() {
if (did_change)
NotifyOnDisplayChanged();
else
- FOR_EACH_OBSERVER(Observer, observers_, OnDisplayModeChangeFailed());
+ FOR_EACH_OBSERVER(
+ Observer, observers_, OnDisplayModeChangeFailed(next_state));
return did_change;
}
@@ -754,7 +755,8 @@ bool OutputConfigurator::SetDisplayMode(OutputState new_state) {
if (output_state_ == new_state)
NotifyOnDisplayChanged();
else
- FOR_EACH_OBSERVER(Observer, observers_, OnDisplayModeChangeFailed());
+ FOR_EACH_OBSERVER(
+ Observer, observers_, OnDisplayModeChangeFailed(new_state));
return true;
}
@@ -816,6 +818,9 @@ void OutputConfigurator::ConfigureOutputs() {
changed = EnterState(display, screen, window, new_state, outputs);
if (changed)
output_state_ = new_state;
+ else
+ FOR_EACH_OBSERVER(
+ Observer, observers_, OnDisplayModeChangeFailed(new_state));
oshima 2013/02/14 00:01:50 I think we need to move this out from xgrab sectio
Jun Mukai 2013/02/14 00:54:03 I have little ideas what you're talking. Can I lea
}
bool is_projecting = IsProjecting(outputs);
XRRFreeScreenResources(screen);
« chromeos/display/output_configurator.h ('K') | « chromeos/display/output_configurator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698