net/android/cert_verify_result_android_list.h - Issue 12212135: Return specific cert verification errors on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/android/cert_verify_result_android_list.h

Issue 12212135: Return specific cert verification errors on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/android/cert_verify_result_android.h ('k') | net/android/java/CertVerifyResultAndroid.template » ('j') | net/android/java/src/org/chromium/net/X509Util.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum.

	7

	8 // This file contains the list of certificate verification results returned

	9 // from Java side to the C++ side.

	10

	11 // Certificate verification could not be conducted.

	12 CERT_VERIFY_RESULT_ANDROID(FAILED, -1)

	13

	14 // Certificate is trusted.

	15 CERT_VERIFY_RESULT_ANDROID(OK, 0)

	16

	17 // Certificate is not trusted due to non-trusted root of the certificate chain.

	18 CERT_VERIFY_RESULT_ANDROID(NO_TRUSTED_ROOT, 1)

	19

	20 // Certificate is not trusted because it has expired.

	21 CERT_VERIFY_RESULT_ANDROID(EXPIRED, 2)

	22

	23 // Certificate is not trusted because it is not valid yet.

	24 CERT_VERIFY_RESULT_ANDROID(NOT_YET_VALID, 3)

	25

	26 // Certificate is not trusted because it could not be parsed.

	27 CERT_VERIFY_RESULT_ANDROID(UNABLE_TO_PARSE, 4)
	Ryan Sleevi 2013/02/13 01:41:39 For the values here, it seems better if you used e For the values here, it seems better if you used either the net_error_list style numbering (that is: consistently negative values) or you used the cert_status flag style numbering (that is, a single bit for each possible error). ppi 2013/02/13 12:34:56 Thanks, I have moved to non-positive numbering (0 Show quoted text On 2013/02/13 01:41:39, Ryan Sleevi wrote: > For the values here, it seems better if you used either the net_error_list style > numbering (that is: consistently negative values) or you used the cert_status > flag style numbering (that is, a single bit for each possible error). Thanks, I have moved to non-positive numbering (0 for OK, negative integers for errors) in patch set 2.
OLD	NEW