Issue 12212130: Files.app: prevent to show translation bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212130: Files.app: prevent to show translation bar. (Closed)

Created:
7 years, 10 months ago by yoshiki

Modified:
7 years, 10 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: prevent to show translation bar. Adding the meta tag to prevent translate on Files.app. BUG=175361 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181931

Patch Set 2 : review fix #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/file_manager/main.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm with a one comment. https://codereview.chromium.org/12212130/diff/1/chrome/browser/resources/file_manager/main.html File chrome/browser/resources/file_manager/main.html (right): https://codereview.chromium.org/12212130/diff/1/chrome/browser/resources/file_manager/main.html#newcode15 chrome/browser/resources/file_manager/main.html:15: <meta name="google" value="notranslate" /> ...

7 years, 10 months ago (2013-02-12 14:26:27 UTC) #2

yoshiki

7 years, 10 months ago (2013-02-12 14:44:58 UTC) #3

https://codereview.chromium.org/12212130/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/main.html (right):

https://codereview.chromium.org/12212130/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/main.html:15: <meta name="google"
value="notranslate" />
On 2013/02/12 14:26:27, mtomasz wrote:
> Personally I prefer xhtml syntax, but in html5 we don't close meta I think.

I didn't know that. Changed to html5 style. Thanks.

Expand Messages | Collapse Messages

Issue 12212130: Files.app: prevent to show translation bar. (Closed)

Description

Patch Set 1 #

Patch Set 2 : review fix #

Messages