chrome/browser/ui/uma_browsing_activity_observer.cc - Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/uma_browsing_activity_observer.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r182110 Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_cocoa_browsertest.mm ('k') | chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/uma_browsing_activity_observer.cc

diff --git a/chrome/browser/ui/uma_browsing_activity_observer.cc b/chrome/browser/ui/uma_browsing_activity_observer.cc

index 6ae607a537a6ce968ad9ac83b21e94a1b135b415..85e01ba2a91da03854662f44536a0099f6e2d4aa 100644

--- a/chrome/browser/ui/uma_browsing_activity_observer.cc

+++ b/chrome/browser/ui/uma_browsing_activity_observer.cc

@@ -6,8 +6,8 @@

#include "base/metrics/histogram.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_iterator.h"

-#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/chrome_notification_types.h"

@@ -25,7 +25,8 @@ UMABrowsingActivityObserver* g_instance = NULL;

// static

void UMABrowsingActivityObserver::Init() {

DCHECK(!g_instance);

- DCHECK(BrowserList::empty()); // Must be created before any Browsers are.

+ // Must be created before any Browsers are.

+ DCHECK_EQ(0U, chrome::GetTotalBrowserCount());

g_instance = new UMABrowsingActivityObserver;

}