Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7570)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r182110 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_finder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 6d7a8e36b27d72d88f0cd56001c8caff59d11082..ca2fad8999d53ca0d02895489eea364c988a50f8 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -33,7 +33,6 @@
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_iterator.h"
-#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_ui_prefs.h"
@@ -465,7 +464,7 @@ class BeforeUnloadAtQuitWithTwoWindows : public InProcessBrowserTest {
CycleRunLoops();
// At this point, quit should be for real now.
- ASSERT_EQ(0u, BrowserList::size());
+ ASSERT_EQ(0u, chrome::GetTotalBrowserCount());
}
// A helper function that cycles the MessageLoop, and on Mac, the Cocoa run
@@ -1714,19 +1713,19 @@ IN_PROC_BROWSER_TEST_F(RunInBackgroundTest, RunInBackgroundBasicTest) {
// Close the browser window, then open a new one - the browser should keep
// running.
Profile* profile = browser()->profile();
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
content::WindowedNotificationObserver observer(
chrome::NOTIFICATION_BROWSER_CLOSED,
content::Source<Browser>(browser()));
chrome::CloseWindow(browser());
observer.Wait();
- EXPECT_EQ(0u, BrowserList::size());
+ EXPECT_EQ(0u, chrome::GetTotalBrowserCount());
ui_test_utils::BrowserAddedObserver browser_added_observer;
chrome::NewEmptyWindow(profile);
browser_added_observer.WaitForSingleNewBrowser();
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
}
// Tests to ensure that the browser continues running in the background after
@@ -1743,14 +1742,14 @@ class NoStartupWindowTest : public BrowserTest {
IN_PROC_BROWSER_TEST_F(NoStartupWindowTest, NoStartupWindowBasicTest) {
// No browser window should be started by default.
- EXPECT_EQ(0u, BrowserList::size());
+ EXPECT_EQ(0u, chrome::GetTotalBrowserCount());
// Starting a browser window should work just fine.
ui_test_utils::BrowserAddedObserver browser_added_observer;
CreateBrowser(ProfileManager::GetDefaultProfile());
browser_added_observer.WaitForSingleNewBrowser();
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
}
// Chromeos needs to track app windows because it considers them to be part of
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698