Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r182110 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_main_browsertest.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc
diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
index 2bcfa72a394470d0e38564fcd107be13c8b093b4..b06b0d85d9962f26037d6a1ab73dd93fc8ac823b 100644
--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc
+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc
@@ -83,16 +83,17 @@ std::string BrowserListTabContentsProvider::GetPageThumbnailData(
}
RenderViewHost* BrowserListTabContentsProvider::CreateNewTarget() {
- if (BrowserList::empty())
- chrome::NewEmptyWindow(profile_);
-
- if (BrowserList::empty())
- return NULL;
-
// TODO(gab): Do not hardcode HOST_DESKTOP_TYPE_NATIVE below once
// chrome::NewEmptyWindow() above has been made multi-desktop friendly.
const chrome::BrowserListImpl* browser_list =
chrome::BrowserListImpl::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);
+
+ if (browser_list->empty())
+ chrome::NewEmptyWindow(profile_);
+
+ if (browser_list->empty())
+ return NULL;
+
content::WebContents* web_contents = chrome::AddSelectedTabWithURL(
browser_list->get(0),
GURL(chrome::kAboutBlankURL),
« no previous file with comments | « chrome/browser/chrome_main_browsertest.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698