Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r182110 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_commands_unittest.cc
diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc
index 15155a8357aea54b628586fefb72827a8293ce07..1422469a877d386e90b5ccae133a66f79373b37b 100644
--- a/chrome/browser/browser_commands_unittest.cc
+++ b/chrome/browser/browser_commands_unittest.cc
@@ -7,7 +7,7 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/browser_with_test_window_test.h"
@@ -76,13 +76,13 @@ TEST_F(BrowserCommandsTest, DuplicateTab) {
EXPECT_EQ(3, orig_controller.GetEntryCount());
EXPECT_TRUE(orig_controller.GetPendingEntry());
- size_t initial_window_count = BrowserList::size();
+ size_t initial_window_count = chrome::GetTotalBrowserCount();
// Duplicate the tab.
chrome::ExecuteCommand(browser(), IDC_DUPLICATE_TAB);
// The duplicated tab should not end up in a new window.
- size_t window_count = BrowserList::size();
+ size_t window_count = chrome::GetTotalBrowserCount();
ASSERT_EQ(initial_window_count, window_count);
// And we should have a newly duplicated tab.
@@ -113,13 +113,13 @@ TEST_F(BrowserCommandsTest, ViewSource) {
EXPECT_EQ(1, orig_controller.GetEntryCount());
EXPECT_TRUE(orig_controller.GetPendingEntry());
- size_t initial_window_count = BrowserList::size();
+ size_t initial_window_count = chrome::GetTotalBrowserCount();
// View Source.
chrome::ExecuteCommand(browser(), IDC_VIEW_SOURCE);
// The view source tab should not end up in a new window.
- size_t window_count = BrowserList::size();
+ size_t window_count = chrome::GetTotalBrowserCount();
ASSERT_EQ(initial_window_count, window_count);
// And we should have a newly duplicated tab.
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698