Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r182110 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/uma_browsing_activity_observer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/web_dialogs/web_dialog_web_contents_delegate.h" 5 #include "ui/web_dialogs/web_dialog_web_contents_delegate.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/browser/history/history_types.h" 11 #include "chrome/browser/history/history_types.h"
12 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/browser_list.h" 13 #include "chrome/browser/ui/browser_finder.h"
14 #include "chrome/browser/ui/tabs/tab_strip_model.h" 14 #include "chrome/browser/ui/tabs/tab_strip_model.h"
15 #include "chrome/browser/ui/webui/chrome_web_contents_handler.h" 15 #include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
16 #include "chrome/common/url_constants.h" 16 #include "chrome/common/url_constants.h"
17 #include "chrome/test/base/browser_with_test_window_test.h" 17 #include "chrome/test/base/browser_with_test_window_test.h"
18 #include "chrome/test/base/test_browser_window.h" 18 #include "chrome/test/base/test_browser_window.h"
19 #include "chrome/test/base/testing_profile.h" 19 #include "chrome/test/base/testing_profile.h"
20 #include "content/public/browser/web_contents.h" 20 #include "content/public/browser/web_contents.h"
21 #include "content/public/test/web_contents_tester.h" 21 #include "content/public/test/web_contents_tester.h"
22 #include "googleurl/src/gurl.h" 22 #include "googleurl/src/gurl.h"
23 #include "testing/gmock/include/gmock/gmock.h" 23 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 history::HistoryAddPageArgs should_add_args( 67 history::HistoryAddPageArgs should_add_args(
68 GURL(), base::Time::Now(), 0, 0, GURL(), history::RedirectList(), 68 GURL(), base::Time::Now(), 0, 0, GURL(), history::RedirectList(),
69 content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false); 69 content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false);
70 test_web_contents_delegate_->NavigationStateChanged(NULL, 0); 70 test_web_contents_delegate_->NavigationStateChanged(NULL, 0);
71 test_web_contents_delegate_->ActivateContents(NULL); 71 test_web_contents_delegate_->ActivateContents(NULL);
72 test_web_contents_delegate_->LoadingStateChanged(NULL); 72 test_web_contents_delegate_->LoadingStateChanged(NULL);
73 test_web_contents_delegate_->CloseContents(NULL); 73 test_web_contents_delegate_->CloseContents(NULL);
74 test_web_contents_delegate_->UpdateTargetURL(NULL, 0, GURL()); 74 test_web_contents_delegate_->UpdateTargetURL(NULL, 0, GURL());
75 test_web_contents_delegate_->MoveContents(NULL, gfx::Rect()); 75 test_web_contents_delegate_->MoveContents(NULL, gfx::Rect());
76 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 76 EXPECT_EQ(0, browser()->tab_strip_model()->count());
77 EXPECT_EQ(1U, BrowserList::size()); 77 EXPECT_EQ(1U, chrome::GetTotalBrowserCount());
78 } 78 }
79 79
80 TEST_F(WebDialogWebContentsDelegateTest, OpenURLFromTabTest) { 80 TEST_F(WebDialogWebContentsDelegateTest, OpenURLFromTabTest) {
81 test_web_contents_delegate_->OpenURLFromTab( 81 test_web_contents_delegate_->OpenURLFromTab(
82 NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), Referrer(), 82 NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), Referrer(),
83 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false)); 83 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
84 // This should create a new foreground tab in the existing browser. 84 // This should create a new foreground tab in the existing browser.
85 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 85 EXPECT_EQ(1, browser()->tab_strip_model()->count());
86 EXPECT_EQ(1U, BrowserList::size()); 86 EXPECT_EQ(1U, chrome::GetTotalBrowserCount());
87 } 87 }
88 88
89 TEST_F(WebDialogWebContentsDelegateTest, AddNewContentsForegroundTabTest) { 89 TEST_F(WebDialogWebContentsDelegateTest, AddNewContentsForegroundTabTest) {
90 WebContents* contents = 90 WebContents* contents =
91 WebContentsTester::CreateTestWebContents(profile(), NULL); 91 WebContentsTester::CreateTestWebContents(profile(), NULL);
92 test_web_contents_delegate_->AddNewContents( 92 test_web_contents_delegate_->AddNewContents(
93 NULL, contents, NEW_FOREGROUND_TAB, gfx::Rect(), false, NULL); 93 NULL, contents, NEW_FOREGROUND_TAB, gfx::Rect(), false, NULL);
94 // This should create a new foreground tab in the existing browser. 94 // This should create a new foreground tab in the existing browser.
95 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 95 EXPECT_EQ(1, browser()->tab_strip_model()->count());
96 EXPECT_EQ(1U, BrowserList::size()); 96 EXPECT_EQ(1U, chrome::GetTotalBrowserCount());
97 } 97 }
98 98
99 TEST_F(WebDialogWebContentsDelegateTest, DetachTest) { 99 TEST_F(WebDialogWebContentsDelegateTest, DetachTest) {
100 EXPECT_EQ(profile(), test_web_contents_delegate_->browser_context()); 100 EXPECT_EQ(profile(), test_web_contents_delegate_->browser_context());
101 test_web_contents_delegate_->Detach(); 101 test_web_contents_delegate_->Detach();
102 EXPECT_EQ(NULL, test_web_contents_delegate_->browser_context()); 102 EXPECT_EQ(NULL, test_web_contents_delegate_->browser_context());
103 // Now, none of the following calls should do anything. 103 // Now, none of the following calls should do anything.
104 test_web_contents_delegate_->OpenURLFromTab( 104 test_web_contents_delegate_->OpenURLFromTab(
105 NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), Referrer(), 105 NULL, OpenURLParams(GURL(chrome::kAboutBlankURL), Referrer(),
106 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false)); 106 NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false));
107 test_web_contents_delegate_->AddNewContents(NULL, NULL, NEW_FOREGROUND_TAB, 107 test_web_contents_delegate_->AddNewContents(NULL, NULL, NEW_FOREGROUND_TAB,
108 gfx::Rect(), false, NULL); 108 gfx::Rect(), false, NULL);
109 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 109 EXPECT_EQ(0, browser()->tab_strip_model()->count());
110 EXPECT_EQ(1U, BrowserList::size()); 110 EXPECT_EQ(1U, chrome::GetTotalBrowserCount());
111 } 111 }
112 112
113 } // namespace 113 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/uma_browsing_activity_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698