Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Issue 12212120: Replace most BrowserList::empty() and BrowserList::size() calls by multi-desktop aware calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r182110 Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/sessions/session_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/print_preview_dialog_controller.h" 5 #include "chrome/browser/printing/print_preview_dialog_controller.h"
6 #include "chrome/browser/printing/print_preview_test.h" 6 #include "chrome/browser/printing/print_preview_test.h"
7 #include "chrome/browser/printing/print_view_manager.h" 7 #include "chrome/browser/printing/print_view_manager.h"
8 #include "chrome/browser/ui/browser_commands.h" 8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/browser_list.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h" 11 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
12 #include "content/public/browser/navigation_details.h" 12 #include "content/public/browser/navigation_details.h"
13 #include "content/public/browser/notification_service.h" 13 #include "content/public/browser/notification_service.h"
14 #include "content/public/browser/notification_types.h" 14 #include "content/public/browser/notification_types.h"
15 #include "content/public/common/url_constants.h" 15 #include "content/public/common/url_constants.h"
16 16
17 using content::WebContents; 17 using content::WebContents;
18 18
19 // Test crashes on Aura due to initiator tab's native view having no parent. 19 // Test crashes on Aura due to initiator tab's native view having no parent.
20 // http://crbug.com/104284 20 // http://crbug.com/104284
21 #if defined(USE_AURA) 21 #if defined(USE_AURA)
22 #define MAYBE_GetOrCreatePreviewDialog DISABLED_GetOrCreatePreviewDialog 22 #define MAYBE_GetOrCreatePreviewDialog DISABLED_GetOrCreatePreviewDialog
23 #define MAYBE_MultiplePreviewDialogs DISABLED_MultiplePreviewDialogs 23 #define MAYBE_MultiplePreviewDialogs DISABLED_MultiplePreviewDialogs
24 #define MAYBE_ClearInitiatorTabDetails DISABLED_ClearInitiatorTabDetails 24 #define MAYBE_ClearInitiatorTabDetails DISABLED_ClearInitiatorTabDetails
25 #else 25 #else
26 #define MAYBE_GetOrCreatePreviewDialog GetOrCreatePreviewDialog 26 #define MAYBE_GetOrCreatePreviewDialog GetOrCreatePreviewDialog
27 #define MAYBE_MultiplePreviewDialogs MultiplePreviewDialogs 27 #define MAYBE_MultiplePreviewDialogs MultiplePreviewDialogs
28 #define MAYBE_ClearInitiatorTabDetails ClearInitiatorTabDetails 28 #define MAYBE_ClearInitiatorTabDetails ClearInitiatorTabDetails
29 #endif 29 #endif
30 30
31 namespace printing { 31 namespace printing {
32 32
33 typedef PrintPreviewTest PrintPreviewDialogControllerUnitTest; 33 typedef PrintPreviewTest PrintPreviewDialogControllerUnitTest;
34 34
35 // Create/Get a preview dialog for initiator tab. 35 // Create/Get a preview dialog for initiator tab.
36 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_GetOrCreatePreviewDialog) { 36 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_GetOrCreatePreviewDialog) {
37 // Lets start with one window with one tab. 37 // Lets start with one window with one tab.
38 EXPECT_EQ(1u, BrowserList::size()); 38 EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
39 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 39 EXPECT_EQ(0, browser()->tab_strip_model()->count());
40 chrome::NewTab(browser()); 40 chrome::NewTab(browser());
41 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 41 EXPECT_EQ(1, browser()->tab_strip_model()->count());
42 42
43 // Create a reference to initiator tab contents. 43 // Create a reference to initiator tab contents.
44 WebContents* initiator_tab = 44 WebContents* initiator_tab =
45 browser()->tab_strip_model()->GetActiveWebContents(); 45 browser()->tab_strip_model()->GetActiveWebContents();
46 46
47 PrintPreviewDialogController* dialog_controller = 47 PrintPreviewDialogController* dialog_controller =
48 PrintPreviewDialogController::GetInstance(); 48 PrintPreviewDialogController::GetInstance();
(...skipping 18 matching lines...) Expand all
67 67
68 // 1:1 relationship between initiator tab and preview dialog. 68 // 1:1 relationship between initiator tab and preview dialog.
69 EXPECT_EQ(new_preview_dialog, preview_dialog); 69 EXPECT_EQ(new_preview_dialog, preview_dialog);
70 } 70 }
71 71
72 // Tests multiple print preview dialogs exist in the same browser for 72 // Tests multiple print preview dialogs exist in the same browser for
73 // different initiator tabs. If a preview dialog already exists for an 73 // different initiator tabs. If a preview dialog already exists for an
74 // initiator tab, that initiator tab gets focused. 74 // initiator tab, that initiator tab gets focused.
75 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_MultiplePreviewDialogs) { 75 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_MultiplePreviewDialogs) {
76 // Lets start with one window and two tabs. 76 // Lets start with one window and two tabs.
77 EXPECT_EQ(1u, BrowserList::size()); 77 EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
78 TabStripModel* tab_strip_model = browser()->tab_strip_model(); 78 TabStripModel* tab_strip_model = browser()->tab_strip_model();
79 ASSERT_TRUE(tab_strip_model); 79 ASSERT_TRUE(tab_strip_model);
80 80
81 EXPECT_EQ(0, tab_strip_model->count()); 81 EXPECT_EQ(0, tab_strip_model->count());
82 82
83 // Create some new initiator tabs. 83 // Create some new initiator tabs.
84 chrome::NewTab(browser()); 84 chrome::NewTab(browser());
85 WebContents* web_contents_1 = tab_strip_model->GetActiveWebContents(); 85 WebContents* web_contents_1 = tab_strip_model->GetActiveWebContents();
86 ASSERT_TRUE(web_contents_1); 86 ASSERT_TRUE(web_contents_1);
87 87
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 // When we get the preview dialog for |web_contents_1|, 131 // When we get the preview dialog for |web_contents_1|,
132 // |preview_dialog_1| is activated and focused. 132 // |preview_dialog_1| is activated and focused.
133 dialog_controller->GetOrCreatePreviewDialog(web_contents_1); 133 dialog_controller->GetOrCreatePreviewDialog(web_contents_1);
134 EXPECT_EQ(tab_1_index, tab_strip_model->active_index()); 134 EXPECT_EQ(tab_1_index, tab_strip_model->active_index());
135 } 135 }
136 136
137 // Check clearing the initiator tab details associated with a print preview 137 // Check clearing the initiator tab details associated with a print preview
138 // dialog allows the initiator tab to create another print preview dialog. 138 // dialog allows the initiator tab to create another print preview dialog.
139 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_ClearInitiatorTabDetails) { 139 TEST_F(PrintPreviewDialogControllerUnitTest, MAYBE_ClearInitiatorTabDetails) {
140 // Lets start with one window with one tab. 140 // Lets start with one window with one tab.
141 EXPECT_EQ(1u, BrowserList::size()); 141 EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
142 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 142 EXPECT_EQ(0, browser()->tab_strip_model()->count());
143 chrome::NewTab(browser()); 143 chrome::NewTab(browser());
144 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 144 EXPECT_EQ(1, browser()->tab_strip_model()->count());
145 145
146 // Create a reference to initiator tab contents. 146 // Create a reference to initiator tab contents.
147 WebContents* initiator_tab = 147 WebContents* initiator_tab =
148 browser()->tab_strip_model()->GetActiveWebContents(); 148 browser()->tab_strip_model()->GetActiveWebContents();
149 149
150 PrintPreviewDialogController* dialog_controller = 150 PrintPreviewDialogController* dialog_controller =
151 PrintPreviewDialogController::GetInstance(); 151 PrintPreviewDialogController::GetInstance();
(...skipping 17 matching lines...) Expand all
169 dialog_controller->GetOrCreatePreviewDialog(initiator_tab); 169 dialog_controller->GetOrCreatePreviewDialog(initiator_tab);
170 170
171 // New print preview dialog is a constrained window, so the number of tabs is 171 // New print preview dialog is a constrained window, so the number of tabs is
172 // still 1. 172 // still 1.
173 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 173 EXPECT_EQ(1, browser()->tab_strip_model()->count());
174 // Verify a new print preview dialog has been created. 174 // Verify a new print preview dialog has been created.
175 EXPECT_NE(new_preview_dialog, preview_dialog); 175 EXPECT_NE(new_preview_dialog, preview_dialog);
176 } 176 }
177 177
178 } // namespace printing 178 } // namespace printing
OLDNEW
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/sessions/session_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698