Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issue 12212117: views: Dispatch mouse events using EventDispatch interface too. (Closed)

Created:
7 years, 10 months ago by sadrul
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

views: Dispatch mouse events using EventDispatch interface too. Some of the notable changes: * View::OnMouseEntered and OnMouseExited functions will now be triggered with the correct event-types (i.e. ET_MOUSE_ENTERED and ET_MOUSE_EXITED). These used to be triggered with ET_MOUSE_MOVED before. * Introduce View::GetDragInfo(). This allows a View to reach into the RootView's drag_info and update it as necessary for dragging. * View override of OnMouseEvent() triggers the appropriate callback (e.g. OnMousePressed, OnMouseRelease etc.), instead of the RootView directly calling into these methods. BUG=173235 (Previously committed in r182804, and reverted in r182864 because it broke some tests) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183039

Patch Set 1 #

Patch Set 2 : tot-merge #

Patch Set 3 : revert-revert #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -81 lines) Patch
M ui/views/view.h View 4 chunks +23 lines, -23 lines 0 comments Download
M ui/views/view.cc View 4 chunks +50 lines, -9 lines 0 comments Download
M ui/views/widget/root_view.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 2 3 11 chunks +61 lines, -48 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
This is the last remaining piece for views to use EventDispatcher to dispatch events (https://codereview.chromium.org/12207092/ ...
7 years, 10 months ago (2013-02-11 20:14:12 UTC) #1
Ben Goodger (Google)
7 years, 10 months ago (2013-02-14 23:28:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698