Issue 12212107: Layout tests expect the time to be relative to the unix epoch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212107: Layout tests expect the time to be relative to the unix epoch. (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 10 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Layout tests expect the time to be relative to the unix epoch. base::Time is relative to the windows epoch, and base::TimeTicks is entirely platform dependent. Decision: use base::Time and manually shift it relative to the unix epoch This fixes fast/mediastream/RTCPeerConnection-stats*html BUG=none R=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181919

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webkit/support/webkit_support.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Can you mention which tests this fixes?

Expand Messages | Collapse Messages