runtime/vm/intermediate_language_ia32.cc - Issue 12212093: Convert some compiler passes to preserve valid def-use chains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 12212093: Convert some compiler passes to preserve valid def-use chains. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Incorporated review comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index e9e280e804312adecf54aba2ec2bf55f14011f20..eff49d8b39a3ae5c96d435c4124eacf665cdd6e2 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -796,7 +796,6 @@ void EqualityCompareInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

ASSERT((kind() == Token::kNE) || (kind() == Token::kEQ));

BranchInstr* kNoBranch = NULL;

if (receiver_class_id() == kSmiCid) {

- // Deoptimizes if both arguments not Smi.

EmitSmiComparisonOp(compiler, *locs(), kind(), kNoBranch);

return;

}

« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | no next file » | no next file with comments »