Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: runtime/vm/compiler.cc

Issue 12212093: Convert some compiler passes to preserve valid def-use chains. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index babed804a61f71d152fcb7b1e501a4ec912e9656..f7ac5efdd89425e984e933bf0940482970501cc8 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -178,9 +178,6 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
FlowGraphOptimizer optimizer(flow_graph);
optimizer.ApplyICData();
- // Compute the use lists.
- flow_graph->ComputeUseLists();
-
// Inlining (mutates the flow graph)
if (FLAG_use_inlining) {
TimerScope timer(FLAG_compiler_stats,
@@ -203,14 +200,9 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
// Use propagated class-ids to optimize further.
optimizer.ApplyClassIds();
- // Recompute use lists after applying class ids.
- flow_graph->ComputeUseLists();
-
// Do optimizations that depend on the propagated type information.
optimizer.Canonicalize();
- flow_graph->ComputeUseLists();
-
if (FLAG_constant_propagation) {
ConstantPropagator::Optimize(flow_graph);
// A canonicalization pass to remove e.g. smi checks on smi constants.
@@ -220,9 +212,7 @@ static bool CompileParsedFunctionHelper(const ParsedFunction& parsed_function,
// Unbox doubles. Performed after constant propagation to minimize
// interference from phis merging double values and tagged
// values comming from dead paths.
- flow_graph->ComputeUseLists();
optimizer.SelectRepresentations();
- flow_graph->ComputeUseLists();
if (FLAG_common_subexpression_elimination) {
if (DominatorBasedCSE::Optimize(flow_graph)) {
« no previous file with comments | « no previous file | runtime/vm/flow_graph.h » ('j') | runtime/vm/flow_graph.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698