Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: chrome/browser/task_manager/task_manager_worker_resource_provider.h

Issue 12212089: content: convert child process notifications to observer usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: private Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_worker_resource_provider.h
diff --git a/chrome/browser/task_manager/task_manager_worker_resource_provider.h b/chrome/browser/task_manager/task_manager_worker_resource_provider.h
index 2694498037e805507b783fe5c0120bc8089409be..e2591ca2485f0d84254fac4ba88c985520884822 100644
--- a/chrome/browser/task_manager/task_manager_worker_resource_provider.h
+++ b/chrome/browser/task_manager/task_manager_worker_resource_provider.h
@@ -10,16 +10,15 @@
#include "base/basictypes.h"
#include "chrome/browser/task_manager/task_manager.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/browser_child_process_observer.h"
#include "content/public/browser/worker_service_observer.h"
class TaskManagerSharedWorkerResource;
class TaskManagerWorkerResourceProvider
: public TaskManager::ResourceProvider,
- private content::WorkerServiceObserver,
- private content::NotificationObserver {
+ public content::BrowserChildProcessObserver,
+ private content::WorkerServiceObserver {
public:
explicit TaskManagerWorkerResourceProvider(TaskManager* task_manager);
@@ -38,6 +37,12 @@ class TaskManagerWorkerResourceProvider
virtual void StartUpdating() OVERRIDE;
virtual void StopUpdating() OVERRIDE;
+ // content::BrowserChildProcessObserver implementation.
+ virtual void BrowserChildProcessHostConnected(
+ const content::ChildProcessData& data) OVERRIDE;
+ virtual void BrowserChildProcessHostDisconnected(
+ const content::ChildProcessData& data) OVERRIDE;
+
// content::WorkerServiceObserver implementation.
virtual void WorkerCreated(const GURL& url,
const string16& name,
@@ -45,11 +50,6 @@ class TaskManagerWorkerResourceProvider
int route_id) OVERRIDE;
virtual void WorkerDestroyed(int process_id, int route_id) OVERRIDE;
- // content::NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
void NotifyWorkerCreated(WorkerResourceHolder* resource_holder);
void NotifyWorkerDestroyed(int process_id, int routing_id);
@@ -68,7 +68,6 @@ class TaskManagerWorkerResourceProvider
// have already received WorkerCreated event. We don't add such workers to
// the task manager until the process is launched.
ProcessIdToWorkerResources launching_workers_;
- content::NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(TaskManagerWorkerResourceProvider);
};

Powered by Google App Engine
This is Rietveld 408576698