Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.h

Issue 12212089: content: convert child process notifications to observer usage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: private Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_resource_providers.h
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.h b/chrome/browser/task_manager/task_manager_resource_providers.h
index 81d9cdd8fb86fec3ec6134b5a3871b8b7660aac4..f5cef0eff1944491f8a8fcc970b8173b545a0ff2 100644
--- a/chrome/browser/task_manager/task_manager_resource_providers.h
+++ b/chrome/browser/task_manager/task_manager_resource_providers.h
@@ -12,6 +12,7 @@
#include "base/compiler_specific.h"
#include "base/process_util.h"
#include "chrome/browser/task_manager/task_manager.h"
+#include "content/public/browser/browser_child_process_observer.h"
#include "content/public/browser/child_process_data.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -359,7 +360,7 @@ class TaskManagerChildProcessResource : public TaskManager::Resource {
class TaskManagerChildProcessResourceProvider
: public TaskManager::ResourceProvider,
- public content::NotificationObserver {
+ public content::BrowserChildProcessObserver {
public:
explicit TaskManagerChildProcessResourceProvider(TaskManager* task_manager);
@@ -369,10 +370,11 @@ class TaskManagerChildProcessResourceProvider
virtual void StartUpdating() OVERRIDE;
virtual void StopUpdating() OVERRIDE;
- // content::NotificationObserver method:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
+ // content::BrowserChildProcessObserver methods:
+ virtual void BrowserChildProcessHostConnected(
+ const content::ChildProcessData& data) OVERRIDE;
+ virtual void BrowserChildProcessHostDisconnected(
+ const content::ChildProcessData& data) OVERRIDE;
private:
virtual ~TaskManagerChildProcessResourceProvider();
@@ -386,9 +388,6 @@ class TaskManagerChildProcessResourceProvider
virtual void ChildProcessDataRetreived(
const std::vector<content::ChildProcessData>& child_processes);
- void Add(const content::ChildProcessData& child_process_data);
- void Remove(const content::ChildProcessData& child_process_data);
-
void AddToTaskManager(const content::ChildProcessData& child_process_data);
TaskManager* task_manager_;
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/task_manager/task_manager_resource_providers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698