Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 12212081: Add chromite and pyelftools to DEPS file. (Closed)

Created:
7 years, 10 months ago by rcui1
Modified:
7 years, 9 months ago
Reviewers:
cmp, szager
CC:
chromium-reviews, David James
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add chromite and pyelftools to DEPS file. Used for the Simple Chrome Workflow (go/simple-chrome). pyelftools is a dependency of chromite. BUG=None TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189433

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M DEPS View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rcui1
ptal.
7 years, 10 months ago (2013-02-08 02:58:44 UTC) #1
szager
Can you put them in non-overlayed directories? The way you have it now is incompatible ...
7 years, 10 months ago (2013-02-11 22:21:58 UTC) #2
rcui1
On 2013/02/11 22:21:58, szager wrote: > Can you put them in non-overlayed directories? The way ...
7 years, 10 months ago (2013-02-14 00:23:25 UTC) #3
szager
lgtm, thanks.
7 years, 10 months ago (2013-02-14 23:45:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/12212081/13001
7 years, 10 months ago (2013-02-15 19:07:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) build http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=36661
7 years, 10 months ago (2013-02-15 20:09:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/12212081/23001
7 years, 9 months ago (2013-03-20 19:56:55 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 22:21:30 UTC) #8
Message was sent while issue was closed.
Change committed as 189433

Powered by Google App Engine
This is Rietveld 408576698