Issue 12212073: Allows Zip64 extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212073: Allows Zip64 extensions. (Closed)

Created:
7 years, 10 months ago by Sébastien Marchand

Modified:
7 years, 10 months ago

Reviewers:
cmp, iannucci, M-A Ruel

CC:
chromium-reviews, xusydoc+watch_chromium.org, cmp+cc_chromium.org, ilevy+cc_chromium.org, kjellander+cc_chromium.org

Base URL:
https://git.chromium.org/git/chromium/tools/build.git@master

Visibility:
Public.

More Reviews

Description

Allows Zip64 extensions. According to python's documentation :"ZIP64 extensions are disabled by default because the default zip and unzip commands on Unix (the InfoZIP utilities) dont support these extensions". As we use the python zip only on Windows this is not a problem for us and we should enable the ZIP64 extensions. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=182273

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	scripts/common/chromium_utils.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/12212073/1

7 years, 10 months ago (2013-02-13 18:51:09 UTC) #4

Message was sent while issue was closed.

Change committed as 182273

Expand Messages | Collapse Messages