Linux/ChromeOS Chromium style checker cleanup, chrome/browser edition.

chrome/browser/process_singleton_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This test validates that the ProcessSingleton class properly makes sure
 // that there is only one main browser process.
 //
 // It is currently compiled and run on Windows and Posix(non-Mac) platforms.
 // Mac uses system services and ProcessSingletonMac is a noop.  (Maybe it still
 // makes sense to test that the system services are giving the behavior we
@@ skipping 120 matching lines @@
 // Our test fixture that initializes and holds onto a few global vars.
 class ProcessSingletonTest : public InProcessBrowserTest {
  public:
   ProcessSingletonTest()
       // We use a manual reset so that all threads wake up at once when signaled
       // and thus we must manually reset it for each attempt.
       : threads_waker_(true /* manual */, false /* signaled */) {
     EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
   }
 
-  void SetUp() {
+  virtual void SetUp() {
     // Start the threads and create the starters.
     for (size_t i = 0; i < kNbThreads; ++i) {
       chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter"));
       ASSERT_TRUE(chrome_starter_threads_[i]->Start());
       chrome_starters_[i] = new ChromeStarter(
           TestTimeouts::action_max_timeout(), temp_profile_dir_.path());
     }
   }
 
-  void TearDown() {
+  virtual void TearDown() {
     // Stop the threads.
     for (size_t i = 0; i < kNbThreads; ++i)
       chrome_starter_threads_[i]->Stop();
   }
 
   // This method is used to make sure we kill the main browser process after
   // all of its child processes have successfully attached to it. This was added
   // when we realized that if we just kill the parent process right away, we
   // sometimes end up with dangling child processes. If we Sleep for a certain
   // amount of time, we are OK... So we introduced this method to avoid a
   // flaky wait. Instead, we kill all descendants of the main process after we
   // killed it, relying on the fact that we can still get the parent id of a
   // child process, even when the parent dies.
   void KillProcessTree(base::ProcessHandle process_handle) {
     class ProcessTreeFilter : public base::ProcessFilter {
      public:
       explicit ProcessTreeFilter(base::ProcessId parent_pid) {
         ancestor_pids_.insert(parent_pid);
       }
-      virtual bool Includes(const base::ProcessEntry & entry) const {
+      virtual bool Includes(const base::ProcessEntry & entry) const OVERRIDE {
         if (ancestor_pids_.find(entry.parent_pid()) != ancestor_pids_.end()) {
           ancestor_pids_.insert(entry.pid());
           return true;
         } else {
           return false;
         }
       }
      private:
       mutable std::set<base::ProcessId> ancestor_pids_;
     } process_tree_filter(base::GetProcId(process_handle));
@@ skipping 134 matching lines @@
     ASSERT_EQ(static_cast<size_t>(1), pending_starters.size());
     size_t last_index = pending_starters.front();
     pending_starters.clear();
     if (chrome_starters_[last_index]->process_handle_ !=
         base::kNullProcessHandle) {
       KillProcessTree(chrome_starters_[last_index]->process_handle_);
       chrome_starters_[last_index]->done_event_.Wait();
     }
   }
 }