Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.

chrome/browser/extensions/extension_service_unittest.cc

Index: chrome/browser/extensions/extension_service_unittest.cc
===================================================================
--- chrome/browser/extensions/extension_service_unittest.cc	(revision 181040)
+++ chrome/browser/extensions/extension_service_unittest.cc	(working copy)
@@ -318,7 +318,7 @@
                                             const FilePath& path,
                                             Manifest::Location unused,
                                             int creation_flags,
-                                            bool mark_acknowledged) {
+                                            bool mark_acknowledged) OVERRIDE {
     EXPECT_EQ(expected_creation_flags_, creation_flags);
 
     ++ids_found_;
@@ -358,7 +358,7 @@
 
   virtual bool OnExternalExtensionUpdateUrlFound(
       const std::string& id, const GURL& update_url,
-      Manifest::Location location) {
+      Manifest::Location location) OVERRIDE {
     ++ids_found_;
     DictionaryValue* pref;
     // This tests is to make sure that the provider only notifies us of the
@@ -385,7 +385,7 @@
   }
 
   virtual void OnExternalProviderReady(
-      const extensions::ExternalProviderInterface* provider) {
+      const extensions::ExternalProviderInterface* provider) OVERRIDE {
     EXPECT_EQ(provider, provider_.get());
     EXPECT_TRUE(provider->IsReady());
   }
@@ -562,7 +562,7 @@
 
   virtual void Observe(int type,
                        const content::NotificationSource& source,
-                       const content::NotificationDetails& details) {
+                       const content::NotificationDetails& details) OVERRIDE {
     switch (type) {
       case chrome::NOTIFICATION_EXTENSION_LOADED: {
         const Extension* extension =
@@ -1063,9 +1063,9 @@
   PackExtensionTestClient(const FilePath& expected_crx_path,
                           const FilePath& expected_private_key_path);
   virtual void OnPackSuccess(const FilePath& crx_path,
-                             const FilePath& private_key_path);
+                             const FilePath& private_key_path) OVERRIDE;
   virtual void OnPackFailure(const std::string& error_message,
-                             ExtensionCreator::ErrorType type);
+                             ExtensionCreator::ErrorType type) OVERRIDE;
 
  private:
   const FilePath expected_crx_path_;
@@ -4527,7 +4527,7 @@
  private:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
-                       const content::NotificationDetails& details) {
+                       const content::NotificationDetails& details) OVERRIDE {
     switch (type) {
       case chrome::NOTIFICATION_EXTENSIONS_READY:
         ready_ = true;
@@ -5566,7 +5566,7 @@
 // are provided.
 class ExtensionSourcePriorityTest : public ExtensionServiceTest {
  public:
-  void SetUp() {
+  virtual void SetUp() {

[Jeffrey Yasskin, 2013/02/06 22:59:15]

Why no OVERRIDE here?

[Ryan Sleevi, 2013/02/06 23:09:46]

Discussion with Nico on whether overrides from testing (specifically
::testing::Test) should require overrides.

Consistent with our exemptions for WK code, it was decided to exempt
testing::Test from the OVERRIDE requirement, since 'all tests should fail' if
GTest renamed SetUp.

     ExtensionServiceTest::SetUp();
 
     // All tests use a single extension.  Put the id and path in member vars