Update notifications API after review.

chrome/test/data/extensions/api_test/notification/galore/app/controller.js

Index: chrome/test/data/extensions/api_test/notification/galore/app/controller.js
diff --git a/chrome/test/data/extensions/api_test/notification/galore/app/controller.js b/chrome/test/data/extensions/api_test/notification/galore/app/controller.js
index 54e6084ac2e1684ae40cbf27ee37da7e3ac4685a..51f3331f19c67d2bfa80c11569ec3b00cbae0d9e 100644
--- a/chrome/test/data/extensions/api_test/notification/galore/app/controller.js
+++ b/chrome/test/data/extensions/api_test/notification/galore/app/controller.js
@@ -33,10 +33,10 @@ Galore.controller = {
     Galore.NOTIFICATIONS.forEach(function (type) {
       type.notifications.forEach(function (options) {
         this.view.addNotificationButton(
-            type.type,
+            type.templateType,

[miket_OOO, 2013/02/06 18:42:34]

I seem to have broken the @ replacement scheme you use in the button icon URLs,
but I'm not sure how to fix it. Can you help?

[dharcourt, 2013/02/06 21:34:20]

The icons shouldn't be broken, but the button images will be because their URLs
moved down into the property of an object in an array, and replace_() wasn't
written to handle that. The updated replace_() implementation in my comment
below _should_ fix that, but I haven't tested it. If you want, feel free to
leave it broken and I can test and fix that in a separate change list once your
API changes have landed.

             type.name,
             this.replace_(options.iconUrl, this.BUTTON_IMAGE_SIZE),
-            this.notify_.bind(this, type.type, options));
+            this.notify_.bind(this, type.templateType, options));
       }, this);
     }, this);
   },
@@ -67,7 +67,7 @@ Galore.controller = {
 
   /** @private */
   expand_: function(options, type, priority) {
-    var expanded = {type: type, priority: priority};
+    var expanded = {templateType: type, priority: priority};
     Object.keys(options).forEach(function (key) {
       expanded[key] = this.replace_(options[key], this.NOTIFICATION_ICON_SIZE);
     }, this);