Issue 1221203002: Add a flag for building skyx packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221203002: Add a flag for building skyx packages (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a flag for building skyx packages This CL adds a build-time flag for building skyx packages, which make our example Sky applications work offline. We can't enable this flag by default yet because our build bots lack a few Dart packages, but landing this flag will let folks experiment with this feature locally. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2436dddad44a1e1495689394ba18568ea77439a5

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -33 lines)			Patch
M	sky/apk/rules.gni	View	4 chunks	+44 lines, -34 lines	0 comments	Download
M	sky/sdk/example/mine_digger/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	sky/sdk/example/mine_digger/sky.yaml	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	sky/tools/skyx/bin/skyx.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-02 23:41:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2436dddad44a1e1495689394ba18568ea77439a5 (presubmit successful).